Skip to content

Don't store min/max_is_truncated in zone maps for non-string columns - #9206

Open
myrrc wants to merge 1 commit into
developfrom
myrrc/no-is-truncated-col-for-non-strings
Open

Don't store min/max_is_truncated in zone maps for non-string columns#9206
myrrc wants to merge 1 commit into
developfrom
myrrc/no-is-truncated-col-for-non-strings

Conversation

@myrrc

@myrrc myrrc commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Non-string columns zone map values can't be truncated. Don't write them.

Resolves: #7235

@myrrc
myrrc requested a review from onursatici August 5, 2026 17:00
@myrrc myrrc added the changelog/feature A new feature label Aug 5, 2026
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc force-pushed the myrrc/no-is-truncated-col-for-non-strings branch from 6c1b72b to 71facc3 Compare August 5, 2026 17:00
@myrrc
myrrc enabled auto-merge (squash) August 5, 2026 17:00
@robert3005

Copy link
Copy Markdown
Contributor

Instead of this fix can we migrate the file stats to be accumulator based instead of existing enum based. That solves this problem and aligns them with the zonemaps. I was waiting for fix to the sum aggregate to land before though

@myrrc
myrrc requested a review from robert3005 August 5, 2026 17:13
@myrrc

myrrc commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Let's maybe merge this before so we don't have the fields already, and then migrate the stats?

@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 26.63%

⚡ 1 improved benchmark
✅ 1893 untouched benchmarks
⏩ 43 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decode_varbin[(1000, 2)] 78.3 µs 61.8 µs +26.63%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/no-is-truncated-col-for-non-strings (71facc3) with develop (7ad0d9d)2

Open in CodSpeed

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (c8dc903) during the generation of this report, so 7ad0d9d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-string columns store min/max_is_truncated columns in zone map

2 participants